Skip to content

ci: correct the matrix runner comment's invariant - #111

Merged
owine merged 1 commit into
mainfrom
ci/runner-comment-accuracy
Sep 19, 2026
Merged

owine merged 1 commit into
mainfrom
ci/runner-comment-accuracy

Conversation

@owine

@owine owine commented Sep 19, 2026 •

Copy link
Copy Markdown
Owner

Follow-up to #110, reconciling this repo's comment with owine/renovate-config 24ad0fd.

#110 left a comment telling readers to keep a runner: ubuntu-<major>.<minor> shape. That is wrong on two counts: it does not describe the arm leg (ubuntu-26.04-arm), and it implies the suffix sits outside what Renovate tracks.

Verified in lib/modules/datasource/github-runners/index.ts on renovate main — the ubuntu release list contains 26.04 and 26.04-arm as distinct versions. The preset's capture takes the whole remainder after the OS name, which is correct and mirrors the built-in manager's own regex, so both halves land in one PR.

Confirmed the preset's pattern extracts this repo's two legs as ubuntu/26.04 and ubuntu/26.04-arm.

Comment-only; no behaviour change.

Summary by Sourcery

Enhancements:

  • Correct the GitHub Actions runner matrix guidance to document independent tracking of x64 and ARM Ubuntu runner versions.

The comment merged in #110 told readers to keep a
`runner: ubuntu-<major>.<minor>` shape, which describes neither the arm
leg nor what the shared preset's manager actually tracks.

owine/renovate-config 24ad0fd landed the `github-runners` customManager,
and its capture takes the whole remainder after the OS name, suffix
included. That is correct: the datasource's ubuntu release list carries
`26.04` and `26.04-arm` as separate version strings (likewise macos
`15-large`/`15-intel`, windows `11-arm`), so `26.04-arm` is its own
version, not `26.04` with decoration. Treating the suffix as cosmetic
would file the arm leg under the x64 version stream and could propose an
arm label that does not exist, since arm images can lag x64.

Restate the invariant accordingly and point at the preset commit.
Comment-only; no behaviour change.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @owine, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 1 day and 1 hour by commenting @sourcery-ai review. Upgrade to get a review now.

@sourcery-ai

sourcery-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates a workflow-only comment to accurately describe how the shared github-runners manager extracts complete runner versions, including the -arm suffix; behavior is unchanged.

File-Level Changes

Change Details Files
Correct the workflow comment to document the shared github-runners manager and its full-version invariant.
  • Replace the outdated custom-manager name and add the referenced preset revision.
  • Document the required single-line runner: <os>-<version> syntax, including quoted and unquoted forms.
  • Clarify that 26.04-arm is tracked as a distinct datasource version and that the x64 and arm legs may update independently.
.github/workflows/build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@owine
owine merged commit 31430ee into main Sep 19, 2026
14 checks passed
@owine
owine deleted the ci/runner-comment-accuracy branch September 19, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant