ci: correct the matrix runner comment's invariant - #111
Merged
Merged
Conversation
The comment merged in #110 told readers to keep a `runner: ubuntu-<major>.<minor>` shape, which describes neither the arm leg nor what the shared preset's manager actually tracks. owine/renovate-config 24ad0fd landed the `github-runners` customManager, and its capture takes the whole remainder after the OS name, suffix included. That is correct: the datasource's ubuntu release list carries `26.04` and `26.04-arm` as separate version strings (likewise macos `15-large`/`15-intel`, windows `11-arm`), so `26.04-arm` is its own version, not `26.04` with decoration. Treating the suffix as cosmetic would file the arm leg under the x64 version stream and could propose an arm label that does not exist, since arm images can lag x64. Restate the invariant accordingly and point at the preset commit. Comment-only; no behaviour change.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates a workflow-only comment to accurately describe how the shared File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #110, reconciling this repo's comment with owine/renovate-config
24ad0fd.#110 left a comment telling readers to keep a
runner: ubuntu-<major>.<minor>shape. That is wrong on two counts: it does not describe the arm leg (ubuntu-26.04-arm), and it implies the suffix sits outside what Renovate tracks.Verified in
lib/modules/datasource/github-runners/index.tson renovate main — theubunturelease list contains26.04and26.04-armas distinct versions. The preset's capture takes the whole remainder after the OS name, which is correct and mirrors the built-in manager's own regex, so both halves land in one PR.Confirmed the preset's pattern extracts this repo's two legs as
ubuntu/26.04andubuntu/26.04-arm.Comment-only; no behaviour change.
Summary by Sourcery
Enhancements: