Skip to content

technical: add index for foreign keys - #4972

Open
hannesa2 wants to merge 2 commits into
owncloud:masterfrom
hannesa2:add-index-for-foreign-keys
Open

hannesa2 wants to merge 2 commits into
owncloud:masterfrom
hannesa2:add-index-for-foreign-keys

Conversation

@hannesa2

@hannesa2 hannesa2 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

close #4971

@hannesa2
hannesa2 requested a review from a team as a code owner September 5, 2026 14:33
@jesmrec jesmrec changed the title Add index for foreign keys technical: add index for foreign keys Sep 7, 2026
@joragua

joragua commented Sep 11, 2026

Copy link
Copy Markdown
Member

Hi @hannesa2! Thanks for your contribution! 🙌🏻 Just a comment before the CR:

The calens entry is necessary for this fix, so could you add a new commit (chore: add calens file) including all the changelog information? Please don't forget to read the TEMPLATE.md before adding it. Let us know if you have any doubts and we will help you!

@hannesa2

Copy link
Copy Markdown
Contributor Author

It's fine for me, when you maintain this calens stuff.
Btw, you could have this changelog much easier https://github.com/AppDevNext/AndroidChart/blob/9d7d728f6ef501168736184846889c6ad05a14c3/.github/workflows/Android-CI-release.yml#L59

generate_release_notes: true

@joragua

joragua commented Sep 15, 2026

Copy link
Copy Markdown
Member

Thanks for the suggestion! We will take a look at the yaml file that you mentioned 🤔

NOTE: Calens ≠ Release Notes. Calens is used for the changelog, while release notes are intended for end users

@hannesa2

hannesa2 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

With https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes (which is the stuff under the hood) you can make categories of pull request, e.g customer-related, then it generates it by categories, and after this, you can easy delete stuff from output.
But why filter content ? This is the main issue for me. Be transparent !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] CI shows performance issues with Room

2 participants