-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: release 11.0.1 #41867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: release 11.0.1 #41867
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| Bugfix: Ship only the app payload in the release tarballs | ||
|
|
||
| The release bundles contained 13 bundled apps as the working tree they had been | ||
| built in, rather than as the app's release artifact. Each of those app | ||
| directories carried `.git/` (a shallow clone including its pack file), | ||
| `.github/`, `tests/`, `vendor-bin/` and `build/artifacts/`, the last holding a | ||
| second copy of the app's own tarball. That was 101.94 MB of the 441.8 MB | ||
| uncompressed complete tarball, in 16 shipped git repositories. | ||
|
|
||
| Three things made it more than dead weight. `files_antivirus` shipped its | ||
| anti-virus acceptance data, so a ClamAV scan of the tarball, or of any image | ||
| built from it, reported `Eicar-Test-Signature FOUND` and could be rejected by an | ||
| anti-virus gate. The development files were covered by the app's | ||
| `appinfo/signature.json`, so an administrator could not delete them without | ||
| breaking `occ integrity:check-app`. And the shipped `.git/` carried the release | ||
| engineer's clone metadata, including their name and e-mail address. | ||
|
|
||
| The affected app releases have been repackaged, and the release tooling now | ||
| refuses to build a bundle that contains a build working tree, so this cannot | ||
| recur unnoticed. The standard tarball was affected as well, through | ||
| `notifications`. | ||
|
|
||
| https://github.com/owncloud/core/issues/41824 |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised that this is in the
reuiresection ofcomposer.jsonI thought that it was only used by
phpunit, and related dependencies of that.I see that it is also in
require-devofsymfony/translation.Anyway, it doesn't hurt to list it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used it in the occ commands which check app code - if I remember correctly. I dropped them for 11... right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds correct. I didn't find any real uses of
php-parserin our own code when I did a quick search.We could probably move
php-parsertorequire-dev, and then I suppose it would not get included in a production release bundle.