Use branded login background via --oc-login-background-image#13875
Open
dj4oC wants to merge 2 commits into
Open
Use branded login background via --oc-login-background-image#13875dj4oC wants to merge 2 commits into
dj4oC wants to merge 2 commits into
Conversation
dj4oC
force-pushed
the
enhancement/branded-login-background
branch
from
7d5b3a7 to
6bb3600
Compare
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
dj4oC
force-pushed
the
enhancement/branded-login-background
branch
from
6bb3600 to
7e3f346
Compare
|
LukasHirt
requested changes
Jun 12, 2026
LukasHirt
left a comment
LukasHirt
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good but the commit message needs to be updated to follow the conventional commit.
Replace the default login background with the ownCloud branding artwork and apply it through the --oc-login-background-image CSS custom property (set by the Plain layout from theme.json, consumed in login.scss) so a future branding update only needs to change one value. The oCIS IDP login uses the same custom property. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: David Walter <david.walter@kiteworks.com>
dj4oC
force-pushed
the
enhancement/branded-login-background
branch
from
7e3f346 to
12c7d3b
Compare
Contributor
Author
|
@LukasHirt thanks for the review! I've updated the commit message to follow the conventional commits spec — the subject is now |
Use background-size: contain (not cover) for the branded login background (.oc-login) so the ownCloud logo baked into the artwork stays fully visible at every viewport aspect ratio instead of being cut off. A matching solid background color (#3c4d9b, the artwork's edge color) fills any letterbox so it blends seamlessly with the image. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: David Walter <david.walter@kiteworks.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the default login page background (
themes/owncloud/assets/loginBackground.jpg) with the ownCloud branding artwork ("A Kiteworks Company") and changes how it is applied:Plain.vuenow sets the CSS custom property--oc-login-background-imageinstead of an inlinebackground-imagestyle.login.scssconsumes the property on.oc-login.The image still comes from the theme (
loginPage.backgroundImgintheme.json, unchanged) and remains fully customizable. The shared custom property is also used by the oCIS IDP login screen, so a future branding update only needs to change one value.Related
🤖 Generated with Claude Code