Switch to dschmidt/easygettext to use typescript-estree#6833
Conversation
…tree instead of outdated buntis parser
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
left a comment
There was a problem hiding this comment.
let's merge this to unblock nightly translation sync jobs. good as intermediate solution 👍
|
Kudos, SonarCloud Quality Gate passed! |
|
Grmpf. I waited with the force merge until all the build steps were done in CI run https://drone.owncloud.com/owncloud/web/25001 |
|
That was super weird. The lock file contained the npm.polydev.blue registry (for whatever that is). I've changed it now to point to registry.npmjs.org and everything seems fine without SHA changes .... so this is apparently not malicious - just weird |
|
Updated in d486455 - thanks for reacting so fast! ❤️ |








…from typescript-eslint project instead of outdated buntis parser
Description
buntis is outdated and fails to parse newer javascript/typescript syntax like optional chaining.
There is a PR open for porting to the properly maintained typescript-eslint/typescript-estree library, but it hasn't seen any feedback. It does not fix linenumbers anyhow.
I've sent a new PR which also fixes line numbers, I'm not optimistic it will be merged instead ... we should consider creating a fork in owncloud organization. Let's discuss tomorrow...
Related Issue
Motivation and Context
It fixes missing line numbers and parse errors in ts files/vue files using typescript.
How Has This Been Tested?
removed .pot files from .gitignore
used old version to create those files, commited them. used new version and looked at the diff: only a few line numbers diverged slightly, most probably nothing to worry about.
Types of changes
Open tasks: