Set rustfmt edition and style_edition for consistency#2525
Merged
Conversation
mkeeter
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, running
rustfmton an individual file (eg. via an editor plugin) would sometimes produce different formatting than runningcargo fmton the whole workspace. That seems to be becausecargo fmtinfers theeditionandstyle_editionfrom Cargo.toml, butrustfmtneeds them to be set explicitly in .rustfmt.toml.Here's a specific formatting difference in case anyone's curious or wants to test it.
rustfmt(before this PR):cargo fmt(always), andrustfmt(after this PR):So to be clear, this PR does not change the output of
cargo fmt. The only downside I know of is that if we bump the edition of the crates, we'll need to remember to bump it in .rustfmt.toml too.