Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
+ Coverage 71.30% 71.34% +0.04%
==========================================
Files 250 250
Lines 21783 21790 +7
==========================================
+ Hits 15532 15546 +14
+ Misses 5095 5092 -3
+ Partials 1156 1152 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dkharms
approved these changes
Sep 23, 2026
Comment on lines
+140
to
+141
| token: r.Vals[0].Decoded().(string), | ||
| ts: r.Vals[6].Decoded().(uint64), |
Member
There was a problem hiding this comment.
We need to introduce some schema for these records -- now these constants are hard-coded all over the codebase.
Maybe we can do something like:
type Col[T any] struct {
Idx int
Type DataType
}
func (r *Record) Get[T any](c Col[T]) T {
return r.Vals[c.Idx].Decoded().(T)
}I am fine with leaving TODO for that and creating an issue.
Member
Author
There was a problem hiding this comment.
that's correct. we will have to introduce some column and schema objects
| func (a *DistributedAggregator) Next() *query.Record { | ||
| if a.state == ExecutorStateReadingInput { | ||
| // TODO: read from all inputs simultaneously (???) | ||
| var wg sync.WaitGroup |
Member
There was a problem hiding this comment.
Do I understand correctly that we will start at most #shards goroutines? Should we limit how many concurrent goroutines we can start?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parallel inputs reading in aggregator executor
If you have used LLM/AI assistance please provide model name and full prompt: