Skip to content

Show app icon in About tab#151

Merged
pablopunk merged 1 commit into
mainfrom
fix/about-tab-app-icon
May 13, 2026
Merged

Show app icon in About tab#151
pablopunk merged 1 commit into
mainfrom
fix/about-tab-app-icon

Conversation

@pablopunk
Copy link
Copy Markdown
Owner

@pablopunk pablopunk commented May 13, 2026

Closes #144.

  • Generates a 64x64 icon from assets/icon.png
  • Bundles it as an app resource
  • Uses it in the About tab instead of the window SF Symbol

Summary by CodeRabbit

  • Style
    • Updated the app icon in the info view to use a new custom icon asset, replacing the previous system symbol-based icon. The icon now features optimized rendering with improved scaling and sizing for better visual appearance. This enhancement delivers improved visual presentation and overall consistency across the entire application interface.

Review Change Stack

@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
swiftshift-app Ready Ready Preview, Comment May 13, 2026 5:52pm

@pablopunk pablopunk merged commit d50ed12 into main May 13, 2026
5 checks passed
@pablopunk pablopunk deleted the fix/about-tab-app-icon branch May 13, 2026 17:53
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f5615491-1c6b-4aeb-a518-61c4fe9f9024

📥 Commits

Reviewing files that changed from the base of the PR and between 05fcefe and 880b68a.

⛔ Files ignored due to path filters (1)
  • assets/icon-64x64.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • Swift Shift.xcodeproj/project.pbxproj
  • Swift Shift/src/View/InfoView.swift

Walkthrough

This PR addresses issue #144 by replacing the system window icon with the actual app icon in the About tab. The Xcode project is updated to register a new icon-64x64.png asset for build and bundling. The InfoView component is modified to load this asset as an NSImage with a fallback to the application icon, then renders it as a 32×32 resizable image instead of a generic SF Symbol.

Possibly related PRs


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

icon on About tab

1 participant