Repository navigation
Conversation
SQLAlchemy 2.1 treats a pre-existing __dataclass_fields__ as mixed dataclass styles, so MappedAsDataclass bases failed to construct.
Member
davidism
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When wrapping a SQLAlchemy 2.x
model_class,_make_declarative_basecopied the user class__dict__into the newFlaskSQLAlchemyBase. If that class already mixed inMappedAsDataclass, the copy included__dataclass_fields__. SQLAlchemy 2.1 treats that as mixing decorator and base-class dataclass styles and raisesInvalidRequestError.Skip those dataclass bookkeeping keys so
MappedAsDataclasscan apply to the wrapped base. ExistingMappedAsDataclassconstruction tests cover this; verified on SQLAlchemy 2.0.52 and 2.1.0b1.fixes #1420