Repository navigation
build(deps): update devframe to 1.2.2 - #221
Conversation
devframe 1.2.1 ships the hub UI fix from devframes/devframe#425: dock iframes get their title and the standalone hub page gets nav and main landmarks, which clears the frame-title and region axe violations on /__devframes/. Closes pangular-inspector#206
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (6)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe main content region now has an accessible label based on the active tab or view title. Devframe dependency ranges change to ChangesAccessibility and Devframe update
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The main landmark receives a label from the active tab or view title, and the dependency and extension references are consistent. No concrete PR-introduced issue remains to block merging. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to No introduced security weakness was established. The accessible-label change does not add capabilities, and existing entrypoint configuration is unchanged. However, the upgraded dependencies implement security-sensitive behavior that could not be fully compared. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (4 skipped: 4 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
With devframe 1.2.2 the hub page has its own main landmark, and axe compares landmarks across the dock iframe, so the two unnamed mains failed landmark-unique. The panel's main is now named after the active inspector tab.
What and why
Updates
devframeand the@devframes/*packages to^1.2.2(root,packages/devtools,examples/angular-native). 1.2.1 includes devframes/devframe#425, which fixes the two axe violations on the standalone hub page from #206: the dock iframe now has a title, and the page has anav("Docks") and amainlandmark. 1.2.2 adds features we don't use. No code changes were needed.extension/uiis rebuilt because the panel bundles the devframe client.Closes #206
How it was verified
pnpm commit:check,pnpm format:check,pnpm typecheck,pnpm skills:checkpnpm test:devtools(1166) andpnpm test:panelpnpm docs:build,pnpm test:axe,pnpm install --frozen-lockfilepnpm extension:buildandextension/uicommitted/__devframes/with the SSR demo, dark and light:frame-titleandregionare gone; the panel loads live data through the hubNotes for reviewers
With the hub's new
<main>, axe flaggedlandmark-uniquebecause our panel's<main>in the dock iframe was unnamed too. The panel'smainis now named after the active inspector tab (e.g. "Dashboard"), and axe on/__devframes/reports 0 violations in dark and light.Summary by CodeRabbit