Repository navigation
docs: add an Angular Native setup guide and a NativeScript reference page - #226
Conversation
…page Angular Native had a reference page but no step-by-step guide, and NativeScript had a guide but no reference page. Each platform now has both: the guide is the how-to, the reference page says what the panel shows, the options and how it works, and they link to each other. The panel's Angular Native card and the READMEs link to the new guide, and the installation page lists the NativeScript overlay entry.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds an Angular Native setup guide and a NativeScript overview, updates links and navigation for both, and changes the JavaScript bundle references in the extension UI. ChangesSetup documentation
Extension UI bundle references
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The documentation markers render as intended links, and the updated UI bundle references the asset that provides its import. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. (8 skipped: 8 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What and why
Angular Native had a reference page but no step-by-step guide, and NativeScript had a guide but no reference page. Each platform now has both: the guide is the how-to, the reference page covers what the panel shows, the options and how it works, and they link to each other.
guides/angular-native.md("Set up Angular Native"): install, start the overlay aftermount(), runpangular dev(localhost, or--hostfor a device with the trusted-network warning), open the panel, try the demo. The overlay defaults tolocalhost:9999on every platform; Android reaches it withadb reverse.getting-started/angular-native.mdis now the reference page and points to the guide for setup.getting-started/nativescript.md: what the panel shows, controls that have no effect there, where it shows, requirements, options (localhoston iOS,10.0.2.2on Android), how it works and an FAQ.guides/nativescript.mdlinks to it.How it was verified
pnpm commit:check,pnpm format:check,pnpm typecheckpnpm test:devtools(1173) andpnpm test:panel(107)pnpm docs:build(link guards),pnpm test:axepnpm extension:buildandextension/uicommittedinitAngularNativeOverlayoptions, the overlay's log line, theoverlay-nativescriptexport, the example's scripts and the CLI flagsNotes for reviewers
Writing the NativeScript reference page showed some gaps compared with Angular Native: the panel treats a NativeScript app as a browser page (no platform marker), there's no Pipes data, every reconnect gets a new page id, and the server's config (inspector switches, redaction) never reaches the app. The page describes these as they are.
Summary by CodeRabbit