Skip to content

Null ex#72

Merged
papi-ux merged 2 commits into
papi-ux:masterfrom
quarnster:null_ex
Jun 1, 2026
Merged

Null ex#72
papi-ux merged 2 commits into
papi-ux:masterfrom
quarnster:null_ex

Conversation

@quarnster
Copy link
Copy Markdown
Contributor

Summary

This app_grid_item view is opened when selecting "show all apps" on a Sunshine host. As it doesn't contain a "grid_spinner" definition, the app would terminate with a "findViewById must not be null" exception.

Also got another "cannot be null"-exception in getLoaderTask.

Testing

  • I tested the affected build, pairing, stream, input, or UI path.
  • I tested on a real device or emulator when the change affects Android behavior.
  • I included screenshots or recordings for visible UI changes, when practical.
  • I updated docs or release notes when user-facing behavior changed.

@papi-ux
Copy link
Copy Markdown
Owner

papi-ux commented Jun 1, 2026

Thanks for the fix! this is exactly the kind of small crash-path cleanup I appreciate (and need). Lotta moving parts from the Kotlin transition.

I pulled the PR locally and verified the layout contract: app grid layouts doesn't define grid_spinner, while the PC card layout still does. Also ran the affected Android gates on an ARM64 debug build.

Looks good to merge from my side! Tiny non-blocking nit: we could eventually replace the prgView!! in PcGridAdapter with a requireNotNull(...) to make that layout invariant a smidge clearer, but the current fix is right as rain! Appreciate you.

@papi-ux papi-ux merged commit 8bb9ee7 into papi-ux:master Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants