Null ex#72
Merged
Merged
Conversation
Would otherwise crash the app when selecting "view all apps" on a Sunshine host
Owner
|
Thanks for the fix! this is exactly the kind of small crash-path cleanup I appreciate (and need). Lotta moving parts from the Kotlin transition. I pulled the PR locally and verified the layout contract: app grid layouts doesn't define Looks good to merge from my side! Tiny non-blocking nit: we could eventually replace the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This app_grid_item view is opened when selecting "show all apps" on a Sunshine host. As it doesn't contain a "grid_spinner" definition, the app would terminate with a "findViewById must not be null" exception.
Also got another "cannot be null"-exception in getLoaderTask.
Testing