Verify overrides against chain metadata; per-para cores and messaging switches - #129
Merged
Conversation
pepoviola
reviewed
Aug 28, 2026
| /// when the relay's parachains are exactly the ones being bitten, so the | ||
| /// two snapshots agree on channel heads. | ||
| #[arg(long, default_value_t = false, verbatim_doc_comment)] | ||
| keep_messaging_state: bool, |
Collaborator
There was a problem hiding this comment.
@mordamax did you test this with polkadot/kusama?
pepoviola
approved these changes
Aug 28, 2026
Collaborator
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValidatorSet::Validators, which Polkadot/Kusama have no pallet for, was previously written blindly).ValidatorGroupsbug looked like.Configuration::ActiveConfigis read live and patched (num_coresonly) instead of replaced, soexecutor_params, async-backing params andmax_pov_sizeof the bitten chain survive.--para-cores <id>=<n>and--keep-messaging-state(both also settable in the TOML config).Verification needs an RPC endpoint: the relay always has one, a parachain only when
rpc_endpointis set — otherwise overrides fall back to unverified with a warning.Closes #124
Closes #125