Write a bundle manifest describing the bite artifacts - #131
Merged
Conversation
pepoviola
reviewed
Aug 29, 2026
Comment on lines
+23
to
+25
| /// Binaries that produce the snapshots, and whose versions therefore have to | ||
| /// match on restore. | ||
| const SNAPSHOT_BINARIES: [&str; 2] = ["doppelganger", "doppelganger-parachain"]; |
Collaborator
There was a problem hiding this comment.
This is not needed anymore, the binary we use for bite is not needed for spawning later.
Contributor
Author
There was a problem hiding this comment.
removed the version tracking entirely, spawn runs the plain binaries anyway so there was nothing to compare. Turns out doppelganger has no --version either
pepoviola
reviewed
Aug 29, 2026
Comment on lines
+54
to
+56
| /// `--version` of the binaries that produced the snapshots. | ||
| #[serde(default)] | ||
| pub binaries: Vec<(String, String)>, |
Collaborator
There was a problem hiding this comment.
We can remove this part :)
Suggested change
| /// `--version` of the binaries that produced the snapshots. | |
| #[serde(default)] | |
| pub binaries: Vec<(String, String)>, |
pepoviola
reviewed
Aug 29, 2026
Comment on lines
+59
to
+74
| async fn binary_version(cmd: &str) -> Option<String> { | ||
| let out = Command::new(cmd).arg("--version").output().await.ok()?; | ||
| let version = String::from_utf8_lossy(&out.stdout).trim().to_string(); | ||
| (!version.is_empty()).then_some(version) | ||
| } | ||
|
|
||
| pub async fn binary_versions() -> Vec<(String, String)> { | ||
| let mut versions = vec![]; | ||
| for cmd in SNAPSHOT_BINARIES { | ||
| if let Some(version) = binary_version(cmd).await { | ||
| versions.push((cmd.to_string(), version)); | ||
| } | ||
| } | ||
| versions | ||
| } | ||
|
|
pepoviola
reviewed
Aug 29, 2026
Comment on lines
+79
to
+84
| pub fn now_unix() -> u64 { | ||
| SystemTime::now() | ||
| .duration_since(UNIX_EPOCH) | ||
| .map(|d| d.as_secs()) | ||
| .unwrap_or_default() | ||
| } |
Collaborator
There was a problem hiding this comment.
This is weird, is a general helper function that is used from outside this module (and only onces). I think we can un in place or if we still need the helper make a support /helper module.
Contributor
Author
There was a problem hiding this comment.
inlined at the single call site
pepoviola
reviewed
Aug 29, 2026
Comment on lines
+109
to
+141
| /// Compare the binaries that produced the bundle with the ones on this machine. | ||
| /// A mismatch is a warning, not an error: it usually still restores, and when it | ||
| /// does not the failure otherwise looks like a corrupt snapshot. | ||
| /// | ||
| /// Both sides are the *doppelganger* binaries: the bite writes what produced the | ||
| /// snapshots, and a restore needs the same ones to import that state. | ||
| pub async fn warn_on_binary_mismatch(base_path: &Path) { | ||
| let Some(manifest) = Manifest::read(base_path).await else { | ||
| info!("no bundle manifest found, skipping the binary version check"); | ||
| return; | ||
| }; | ||
| if manifest.version != VERSION { | ||
| warn!( | ||
| "bundle manifest is version {} but this build writes {VERSION}; some fields may be missing", | ||
| manifest.version | ||
| ); | ||
| } | ||
| if manifest.binaries.is_empty() { | ||
| info!("bundle manifest records no binary versions, skipping the check"); | ||
| return; | ||
| } | ||
|
|
||
| let local = binary_versions().await; | ||
| for (cmd, bundled) in &manifest.binaries { | ||
| match local.iter().find(|(name, _)| name == cmd) { | ||
| Some((_, current)) if current == bundled => {} | ||
| Some((_, current)) => warn!( | ||
| "{cmd}: bundle was produced with '{bundled}' but this machine has '{current}'; a snapshot from a newer node can fail to restore in ways that look like corruption" | ||
| ), | ||
| None => warn!("{cmd}: not found locally, can't compare with the bundle's '{bundled}'"), | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Again, we can remove this part.
pepoviola
reviewed
Aug 29, 2026
pepoviola
left a comment
pepoviola
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, some small comments 🚀
* Publish the fork's own nodes as bootNodes, optionally under a public host * Pack a step's artifacts into one restorable bundle --------- Co-authored-by: Javier Viola <363911+pepoviola@users.noreply.github.com>
pepoviola
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bite writes
manifest.jsonnext toready.json: per chain the bite block, source RPC, spec/snapshot file names with sizes, any carried upgrade and its hash, and thedoppelganger --versionoutput that produced the snapshots.spawnwarns when the local binaries differ, since a snapshot from a newer node fails to restore in ways that look like corruption.Snapshot sizes are measured when the snapshot is written, because
ZOMBIE_BITE_CI_PATHmoves the files afterwards. Theversionandbundlefields say which bundle the manifest describes and let an older shape be reported instead of silently dropped.Part of #126 — the rest of that issue (specs, snapshots and overrides as one re-restorable artifact) is not in this PR.