Honour --rc-sync-url instead of ignoring it - #135
Closed
mordamax wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relaychainstoredmaybe_sync_urlbut nothing read it: bothsync_endpoint()andrpc_endpoint()returned a hardcoded public URL, so--rc-sync-urland the config'ssync_urldid nothing.Both now use the supplied endpoint when there is one. They share it because the reason to pass the flag — the public endpoint is rate limited, down, or unreachable from where the bite runs — applies equally to the parachain sync and to the reads the bite does against the source.
Closes #134