Skip to content

feat: Add FCM analytics label support#566

Open
jacog2 wants to merge 1 commit intoparse-community:masterfrom
jacog2:codex-fcm-analytics-label
Open

feat: Add FCM analytics label support#566
jacog2 wants to merge 1 commit intoparse-community:masterfrom
jacog2:codex-fcm-analytics-label

Conversation

@jacog2
Copy link
Copy Markdown

@jacog2 jacog2 commented May 11, 2026

Summary

  • Support analytics_label in converted FCM push payloads.
  • Validate labels against Firebase's allowed 1-50 character pattern before mapping to fcmOptions.analyticsLabel.
  • Keep analytics metadata out of the client-visible converted Android/APNS payload data and document usage.

Closes #377.

Validation

  • npm ci completed with existing engine warnings because this machine has Node v25.9.0 while the package supports Node 20/22/24.
  • $env:TESTING='1'; .\node_modules\.bin\jasmine.cmd spec\FCM.spec.js
  • $env:TESTING='1'; .\node_modules\.bin\jasmine.cmd
  • .\node_modules\.bin\eslint.cmd src\FCM.js spec\FCM.spec.js
  • git diff --check

Note: npm run lint was not usable on this Windows checkout because the repository-wide ESLint linebreak-style rule flags untouched CRLF files; the touched JS files pass ESLint directly.

@parse-github-assistant
Copy link
Copy Markdown

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant Bot changed the title feat: add FCM analytics label support feat: Add FCM analytics label support May 11, 2026
@parse-github-assistant
Copy link
Copy Markdown

parse-github-assistant Bot commented May 11, 2026

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Warning

Rate limit exceeded

@jacog2 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 52 minutes and 38 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6d96a138-ce33-4380-ad6a-8299478bff14

📥 Commits

Reviewing files that changed from the base of the PR and between cad9b14 and aa98ecf.

📒 Files selected for processing (3)
  • README.md
  • spec/FCM.spec.js
  • src/FCM.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jacog2
Copy link
Copy Markdown
Author

jacog2 commented May 11, 2026

Ready for review. I kept the PR focused on issue #377 and validated the full Jasmine suite plus ESLint on the touched JS files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Analytics Label Support for FCM Messages in Parse Server Push Adapter

1 participant