fix: unify CLI remediation and clear npm audit findings - #228
Merged
Conversation
Share preferredBinaryRemediationAction between status actions and ensurePatchloomReadyOrNotify so missing/outdated CLI prompts prefer managed install, reinstall, or update over Settings alone. Bump @types/node and brace-expansion override to clear high audit advisories. npm run check: 311 unit tests, coverage, package ok. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Point troubleshooting at the Reinstall action added to preferred binary remediation so Windows/managed users recover without winget. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
SebTardif
marked this pull request as ready for review
August 10, 2026 13:44
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MPI cycle after CLI 0.28.0 alignment (#226).
preferredBinaryRemediationActionand use it from both status preferred actions andensurePatchloomReadyOrNotify, so missing/outdated CLI always prefers managed Install / Reinstall / Update over Settings alone (and avoids lagging winget/Chocolatey upgrade paths).npm audit fix+brace-expansionoverride 5.0.8 → 5.0.9); bump@types/nodeto 26.2.0.Test plan
npm run check(311 unit tests, coverage, package)npm audit→ 0 vulnerabilitiesNote
Release PR #227 (v0.4.0) left open per maintainer; do not merge without explicit approval.