Repository navigation
Add PyBaMM 26.10 support - #23
Closed
DavidMStraub wants to merge 2 commits into
Closed
DavidMStraub wants to merge 2 commits into
DavidMStraub wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR scope is materially under-described, and the README overstates compatibility with arbitrary PyBaMM models.
2 open findings
What changed in this PR
Adds PyBaMM 26.10 support and introduces monolithic DAE model integration.
Changes:
- Updates PyBaMM and PathSim dependency requirements and CI coverage.
- Adds DAE support for DFN and lead-acid models.
- Expands integration tests and documentation.
| File | Description |
|---|---|
src/pathsim_batt/cells/pybamm_cell.py |
Implements DAE integration and algebraic-state handling. |
tests/cells/test_pybamm_cell.py |
Tests DAE behavior and DFN integration. |
tests/cells/test_lead_acid.py |
Extends monolithic coverage to lead-acid DAEs. |
README.md |
Documents broader model support. |
pyproject.toml |
Updates PathSim and PyBaMM requirements. |
.github/workflows/test.yml |
Tests PyBaMM 26.5–26.10. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ## PyBaMM models | ||
|
|
||
| Thermal sub-model and heat-source options are injected automatically — pass the bare model class with no `options=`. | ||
| All blocks accept any PyBaMM battery model, e.g. `lithium_ion.SPM`, `SPMe`, `DFN`, `lead_acid.LOQS`, `lead_acid.Full` or `equivalent_circuit.Thevenin`. Thermal sub-model and heat-source options are injected automatically — pass the bare model class with no `options=`. |
|
|
||
|
|
||
| class _CellBase(DynamicalSystem): | ||
| class _CellBase(SemiExplicitDAE): |
Collaborator
Author
|
Wrong branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the 6-release support policy, 26.4 is dropped and 26.10 is added.
pybamm>=26.5,<26.11(was>=26.4,<26.10)Raising the lower bound means the next pathsim-batt release must be a minor release.
Note: 26.10 deprecates
pybamm.CasadiSolver, which theLOQSworkaround for PyBaMM < 26.7 uses. 26.5 and 26.6 should age out under the policy before PyBaMM removes it.