Repository navigation
Add PyBaMM 26.10 support - #24
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency range, CI matrix, and documentation remain consistent with the six-release support policy.
0 open findings
What changed in this PR
Updates support to the latest six PyBaMM releases, covering 26.5–26.10.
Changes:
- Raises dependency bounds to
>=26.5,<26.11. - Updates CI coverage and the related test comment.
| File | Description |
|---|---|
pyproject.toml |
Updates supported PyBaMM range. |
.github/workflows/test.yml |
Tests PyBaMM 26.5–26.10. |
tests/cells/test_lead_acid.py |
Updates supported-version comment. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the 6-release support policy, 26.4 is dropped and 26.10 is added.
pybamm>=26.5,<26.11(was>=26.4,<26.10)Raising the lower bound means the next pathsim-batt release must be a minor release.
Note: 26.10 deprecates
pybamm.CasadiSolver, which theLOQSworkaround for PyBaMM < 26.7 uses. 26.5 and 26.6 should age out under the policy before PyBaMM removes it.