docs: changelog entries for the gosec pass and the open fix - #26
Merged
Conversation
#24 merged without a changelog entry because CHANGELOG.md itself only arrived in #23, which landed at the same time. This backfills it. Also corrects "No user-facing behavior changes yet", which #24 made false: `namecom open` now rejects an argument that is not a plausible domain name rather than passing it through. Someone who was relying on `open` to accept an arbitrary string will notice, so it belongs under Changed as well as Security. The race fix in #25 is deliberately not listed. It is test-only bookkeeping with no user-visible effect, and Keep a Changelog is for notable changes rather than a commit log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#24 merged without a
CHANGELOG.mdentry, because that file only arrived in #23 and the two landed together. This backfills it.It also corrects a line that #24 made false.
[Unreleased]ended with "No user-facing behavior changes yet" — butnamecom opennow rejects an argument that isn't a plausible domain name rather than passing it through. Anyone relying onopento accept an arbitrary string will notice, so it's listed under Changed as well as Security.The #25 race fix is deliberately not listed: test-only bookkeeping with no user-visible effect, and Keep a Changelog is for notable changes rather than a commit log.
Test plan
[Unreleased]compare link still resolves