test: cover domain requirements and claims

[patramsey]

runClaims and joinYears were at 0.0%, runRequirements at 56.2% — the file overall 25.7% → 90.5%.

These are the commands that tell someone what a registry demands before they try to register, so being wrong here surfaces as a failed registration rather than as a bad-looking table.

Function	Before	After
runRequirements	56.2%	87.5%
runClaims	0.0%	90.9%
joinYears	0.0%	100%

Repo total: 67.2% → 68.3%.

What the 29 cases pin

• TLD canonicalized into the request path (" FR " → fr). The API wants it bare, lowercase, ASCII; .FR 404s.
• Blank TLD rejected before any HTTP call, asserted against a server that fails the test if it's contacted at all.
• Quiet mode lists required field names, sorted. Sorting isn't cosmetic — Go randomizes map iteration, so unsorted output differs run to run and nothing built on it is reproducible. The test asserts exact order.
• Quiet mode prints nothing when a TLD requires no fields, rather than echoing the TLD back.
• The capability table renders both a true and a false flag, so a badge stuck on one value can't pass.
• The table keeps its -o json and --tld-requirement pointers. Without them the nested requirements are unreachable from the default view — which is the entire reason they're printed as a hint instead of flattened into a misleading table.
• claimId: "" counts as unclaimed, not claimed. That distinction decides whether someone is told to pass --acknowledge-claim.
• An inactive claims process is stated explicitly — "no claims found" means something different when nothing was actually checked.
• JSON and YAML carry the nested requirements and the claim id, and omit the human hint.
• A 404 surfaces the API's message.

Verification

Seven mutations, all caught:

Mutation
Drop sort.Strings in quiet mode	✅
Change joinYears empty placeholder	✅
Change joinYears separator	✅
Treat non-nil empty claimId as claimed	✅
Invert the inactive-claims-process notice	✅
Skip TLD canonicalization	✅
Silence the quiet-mode claim id	✅

• 29 subtests confirmed running (not silently skipped) via -v
• golangci-lint run — no issues
• go test -race -count=1 ./... — full suite clean
• go vet ./... clean

Remaining, if you want to keep going

cmd/dns, cmd/url, cmd/email sit at ~66–71% with the same shape of gap — error paths the existing stubs never drive. That's mechanical volume work rather than thinking work.

Still worth an explicit decision rather than drift: cmd/help.go, cmd/cmdutil/complete.go and internal/update are 0% but are help text, shell completion, and a network version check — roughly 6 points of badge for very little confidence.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!