test: cover small units; delete dead IsYes/IsDryRun

[patramsey]

The deletion is the more useful half

cmd.IsYes() and cmd.IsDryRun() in root.go had no callers. Commands use cmdutil.IsYes(cmd) / cmdutil.IsDryRun(cmd) — the context-based pair, ~40 sites. The root.go versions read a package-level struct and were referenced nowhere; package cmd is imported only by main.go, so exporting them reached no one.

They showed up as 0% coverage, and that's exactly the trap: the cheap response is to write a test and turn them green, which preserves dead code and makes the number look better for it. Confirmed dead by deleting them and building.

Then the genuinely cheap units

~55 statements, 68.3% → 69.2%.

ParseFormat / ParseColorMode — validate --output and --color. Both lowercase their input, so --output JSON should work and nothing proved it did. Tests also assert the error names the valid choices, since "unknown format" alone leaves the user guessing. " json" with a leading space is pinned as an error rather than a synonym.

IsNotFound — three statements, but it's what turns a bare 404 into "domain not found — run namecom domain list" across the CLI. It matches through wrapping, so the wrapped cases matter as much as the direct one; commands routinely add context with %w first. 403/500/400 pinned as not-404, and a plain error whose text contains "404" pinned as not matching. Worth having before anyone acts on the pending errors.AsType compiler hint.

UsageError / NewUsageError — stays matchable and unwrappable, and NewUsageError(nil) returns a nil error rather than a non-nil interface holding a nil pointer. That's the typed-nil trap that makes if err != nil true on success.

The update cache — round-trips, honors its 24h TTL on both sides of the boundary, degrades silently to "no cached value" on any malformed content, and writes 0600/0700. Every failure path there is silent by design, so nothing else would have noticed it breaking.

Verification

Ten mutations, all caught:

Mutation		Mutation
Drop ToLower in ParseFormat	✅	Break UsageError.Unwrap	✅
Shorten the format error message	✅	Disable the cache TTL check	✅
Drop ToLower in ParseColorMode	✅	Report empty cached version as valid	✅
Widen IsNotFound to any 4xx	✅	Cache file 0600 → 0644	✅
Force IsNotFound false	✅	Cache dir 0700 → 0755	✅

• golangci-lint run — no issues
• go test -race -count=1 ./... — full suite clean
• go build ./... passes with the dead functions removed

Where I'd stop

This is a reasonable end point for coverage work. What remains at 0% is cmd/help.go, cmd/cmdutil/complete.go, and the interactive huh forms — help text, shell completion, and TUI prompts. Covering those means asserting that help output contains strings you just wrote: a change-detector that fails when you reword help and never when something breaks.

The code that can lose someone a domain or charge them money is the well-covered part now, which is the outcome worth having.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!