Settings: TX Volume becomes a live slider in the AUDIO section#88
Merged
Conversation
You can now actually dial in TX drive while watching your radio's ALC. Two changes, no behavior breakage: 1. The TX Volume editor is now a slider with a big live readout instead of a number-input dialog. Dragging updates GeneralVariables.volumePercent immediately (and posts to the LiveData) so the next TX uses the new level without you having to tap Save first. We persist to the config DB on dismiss. The hardware volume key handler in ComposeMainActivity still works as a ±5% quick-adjust — they share the same state. 2. Moved the row from the TRANSMISSION section (where it sat alongside watchdog / stop-after) into the AUDIO section right under Audio Output. That's where someone tuning audio levels actually expects to find it. Why this matters: on the car-dash with the libusb output path now working, the TX audio is reaching the rig but a touch hot on ALC. Number-input UX was unusable for that — open dialog, type number, save, test, repeat. Slider-with-live-update lets you drag a couple of percent at a time and watch the rig's meter respond in real time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now that the libusb output path is actually pushing audio to the radio (visible on the ALC meter from the latest car-dash test), the level needs to be dialed down a touch. The existing TX Volume control was a number-input dialog buried in the TRANSMISSION section — unusable for live tuning. This makes it a slider with a live readout, in the AUDIO section where someone tuning audio actually expects to find it.
Changes
1. Slider with live update. The editor opens a dialog with:
GeneralVariables.volumePercentimmediately (and posts to the LiveData), so the next TX uses the new level — no Save-button friction2. Moved row from TRANSMISSION → AUDIO. Under Audio Output, where it logically belongs. TRANSMISSION keeps watchdog and stop-after (operating-limits stuff).
The hardware volume key handler in
ComposeMainActivitystill works as a ±5% quick-adjust — both methods sharevolumePercent+ the LiveData so they stay in sync.Workflow in the car
Test plan
assembleDebugcompiles clean (Slider + SliderDefaults imports + the dialog itself).🤖 Generated with Claude Code