Repository navigation
fix(api): authorize personnel, leave and attendance reads - #34
Merged
patrickschiller merged 3 commits intoOct 10, 2026
Merged
Conversation
Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Patrick Schiller <p@trickschiller.de>
…orkflows Signed-off-by: Patrick Schiller <p@trickschiller.de>
patrickschiller
changed the title
patrickschiller
marked this pull request as ready for review
October 10, 2026 08:02
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
patrickschiller
deleted the
codex/fix-authentication-vulnerabilities-in-api
branch
October 10, 2026 08:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Employee profiles, balances and related absence/attendance reads must use the authenticated caller's record scope. This fix rejects anonymous account, leave-allowance and violation reads, and limits employee, account, vacation, absence, leave-allowance and violation data to self, direct reports for managers, or HR administrators. Unfiltered absence lists enforce the same scope.
An authenticated directory exposes only active employee IDs and names so vacation substitutes and manager project assignments remain available without exposing full personnel records. The OpenAPI contract and generated client are updated. The branch incorporates current main and preserves the 2.0.0 work-rule snapshots and break calculations.
Validation: Node 20 / pnpm 9.15.9; full workspace lint, typecheck, builds and 250 unit/integration tests; 20 release/database-safety tests; API end-to-end tests including anonymous access, all role scopes, query spoofing, stale/expired/forged sessions, and data minimization; UI regressions for substitute selection and manager/HR project assignments. No database migrations.