Repository navigation
fix(tests): workshop_ namespace for notifications metric in collection 04 - #2
Merged
Merged
Conversation
…ction 04 collection 04 queried notifications_sent_total but the OTel Collector exports it as workshop_notifications_sent_total, so the 'Notification metric exists' assertion always failed. Same namespace fix already applied to collection 03. Verified 04 passes 8/8 after the fix (Module 4 walkthrough on Quarkus).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection
04-debugging-exercise.jsonqueriednotifications_sent_total, but the OTel Collector exports metrics under theworkshopnamespace (workshop_notifications_sent_total), so the 'Notification metric exists' assertion always failed — even with the Module 4 tier bug fixed. Same fix already applied to collection 03 in the reconciliation PR.Found while running the full Module 4 loop on Quarkus: broken →
tier=unknownon notification spans; fixed →tier=GOLD; and04now passes 8/8.