Skip to content

chore(EmptyState): Update use a RH brand icon in tests#12376

Open
tlabaj wants to merge 1 commit intopatternfly:mainfrom
tlabaj:addressbook_icon
Open

chore(EmptyState): Update use a RH brand icon in tests#12376
tlabaj wants to merge 1 commit intopatternfly:mainfrom
tlabaj:addressbook_icon

Conversation

@tlabaj
Copy link
Copy Markdown
Contributor

@tlabaj tlabaj commented Apr 24, 2026

What: towards #12244

Updated Empty state tests to us a brand icon

Summary by CodeRabbit

  • Tests
    • Updated snapshot test for EmptyState component with revised icon configuration.

@tlabaj tlabaj requested review from a team, kmcfaul and nicolethoen and removed request for a team April 24, 2026 14:46
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 37ec5631-672c-484b-be70-d079dba4db2a

📥 Commits

Reviewing files that changed from the base of the PR and between 51f4467 and 8762198.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/EmptyState/__tests__/__snapshots__/EmptyState.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • packages/react-core/src/components/EmptyState/__tests__/EmptyState.test.tsx

Walkthrough

A snapshot test in the EmptyState component test suite is updated to use a different PatternFly icon component. The test imports and renders rh-ui-document-icon instead of address-book-icon. No test logic or assertions are modified.

Changes

Cohort / File(s) Summary
EmptyState Test Update
packages/react-core/src/components/EmptyState/__tests__/EmptyState.test.tsx
Icon import and prop updated in "Header with icon" snapshot test from address-book-icon to rh-ui-document-icon.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • kmcfaul
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and concisely describes the main change: updating EmptyState tests to use a Red Hat brand icon instead of the address-book icon.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Apr 24, 2026

@tlabaj tlabaj linked an issue Apr 24, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update icons in to RH brand icons [react]

2 participants