Skip to content

chore(BarsIcon): Updat all uses of Bars icons to use RhUiMenuBarsIcon instead#12377

Open
tlabaj wants to merge 1 commit intopatternfly:mainfrom
tlabaj:bars_icon
Open

chore(BarsIcon): Updat all uses of Bars icons to use RhUiMenuBarsIcon instead#12377
tlabaj wants to merge 1 commit intopatternfly:mainfrom
tlabaj:bars_icon

Conversation

@tlabaj
Copy link
Copy Markdown
Contributor

@tlabaj tlabaj commented Apr 24, 2026

What: towards #12244

Summary

Replaces BarsIcon with RhUiMenuBarsIcon (rh-ui-menu-bars-icon) in components, documentation, and the integration demo app so the menu/bars icon uses the Red Hat UI asset.

Changes

  • Update imports from bars-icon to rh-ui-menu-bars-icon.
  • Replace BarsIcon with RhUiMenuBarsIcon in affected examples and demos.

Scope

  • react-core: MenuWithActions, MenuWithFavorites, ActionsMenuDemo, and shared doc imports in related .md files (Page, Masthead, Nav, CustomMenus, NotificationDrawer, RTL, Wizard, and related demos).
  • react-table: Table.md shared imports.
  • react-integration: MenuDemo.tsx.

Summary by CodeRabbit

  • Documentation

    • Updated component examples and demo documentation across multiple packages to use an updated icon component, ensuring consistency in reference materials.
  • Chores

    • Updated icon dependencies in example code and demo files to reflect latest icon module changes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

Walkthrough

This pull request updates icon imports across example and demo files in the react-core, react-integration, and react-table packages by replacing BarsIcon with RhUiMenuBarsIcon from the PatternFly React Icons library. The change is applied consistently to approximately 15 files including documentation and component examples.

Changes

Cohort / File(s) Summary
Masthead Components
packages/react-core/src/components/Masthead/examples/Masthead.md, packages/react-core/src/demos/Masthead.md
Replaces BarsIcon with RhUiMenuBarsIcon import and usage.
Menu Components
packages/react-core/src/components/Menu/examples/Menu.md, packages/react-core/src/components/Menu/examples/MenuWithActions.tsx, packages/react-core/src/components/Menu/examples/MenuWithFavorites.tsx
Replaces BarsIcon with RhUiMenuBarsIcon in imports and MenuItemAction icon references.
Page Components
packages/react-core/src/components/Page/examples/Page.md, packages/react-core/src/demos/Page.md
Replaces BarsIcon with RhUiMenuBarsIcon import in page examples and demos.
Additional Core Demos
packages/react-core/src/demos/CustomMenus/CustomMenus.md, packages/react-core/src/demos/CustomMenus/examples/ActionsMenuDemo.tsx, packages/react-core/src/demos/Nav.md, packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md, packages/react-core/src/demos/RTL/RTL.md, packages/react-core/src/demos/Wizard/WizardDemo.md
Replaces BarsIcon with RhUiMenuBarsIcon import across multiple demo files.
Integration and Table Demos
packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsx, packages/react-table/src/demos/Table.md
Replaces BarsIcon with RhUiMenuBarsIcon in menu and table demo files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10-15 minutes

Possibly related PRs

Suggested reviewers

  • nicolethoen
  • kmcfaul
  • mcoker
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: replacing all uses of BarsIcon with RhUiMenuBarsIcon across the codebase, which is exactly what the changeset implements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tlabaj tlabaj requested review from a team, lboehling, phcox, thatblindgeye and wise-king-sullyman and removed request for a team April 24, 2026 18:41
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md (1)

10-10: Change line 10 to use dist/esm for consistency with other imports in this file.

All other icon imports in NotificationDrawer.md use dist/esm; line 10's dist/js import creates unnecessary inconsistency.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md` at
line 10, Update the import for RhUiMenuBarsIcon to match the other icon imports
by changing the module path from
'@patternfly/react-icons/dist/js/icons/rh-ui-menu-bars-icon' to the esm build,
i.e. import RhUiMenuBarsIcon from
'@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon'; this keeps the
NotificationDrawer.md imports consistent with the rest of the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md`:
- Line 10: Update the import for RhUiMenuBarsIcon to match the other icon
imports by changing the module path from
'@patternfly/react-icons/dist/js/icons/rh-ui-menu-bars-icon' to the esm build,
i.e. import RhUiMenuBarsIcon from
'@patternfly/react-icons/dist/esm/icons/rh-ui-menu-bars-icon'; this keeps the
NotificationDrawer.md imports consistent with the rest of the file.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 32b2fb26-83c4-46db-8e06-f6152a9e50f3

📥 Commits

Reviewing files that changed from the base of the PR and between 69b6225 and 0252229.

📒 Files selected for processing (15)
  • packages/react-core/src/components/Masthead/examples/Masthead.md
  • packages/react-core/src/components/Menu/examples/Menu.md
  • packages/react-core/src/components/Menu/examples/MenuWithActions.tsx
  • packages/react-core/src/components/Menu/examples/MenuWithFavorites.tsx
  • packages/react-core/src/components/Page/examples/Page.md
  • packages/react-core/src/demos/CustomMenus/CustomMenus.md
  • packages/react-core/src/demos/CustomMenus/examples/ActionsMenuDemo.tsx
  • packages/react-core/src/demos/Masthead.md
  • packages/react-core/src/demos/Nav.md
  • packages/react-core/src/demos/NotificationDrawer/NotificationDrawer.md
  • packages/react-core/src/demos/Page.md
  • packages/react-core/src/demos/RTL/RTL.md
  • packages/react-core/src/demos/Wizard/WizardDemo.md
  • packages/react-integration/demo-app-ts/src/components/demos/MenuDemo/MenuDemo.tsx
  • packages/react-table/src/demos/Table.md

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Apr 24, 2026

@tlabaj tlabaj linked an issue Apr 24, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update icons in to RH brand icons [react]

3 participants