Repository navigation
fix(Felt): track docs @patternfly alias versions via the workspace protocol - #12706
Merged
gabipodolnikova merged 1 commit intoNov 2, 2026
Conversation
…otocol
Replace the exact-version pins on the six @patternfly/* npm aliases in
react-docs with workspace ranges:
"@patternfly/react-core": "npm:@rh-felt/react-core@workspace:^"
The exact pins had to match the workspace versions for yarn to link
the aliases to the local packages, so every release of an aliased
package silently broke `yarn install --immutable` (YN0028) until the
pins were bumped in lockstep (patternfly#12705). The `npm:<name>@workspace:^`
form binds each alias to the local workspace regardless of its
current version, so releases no longer require pin bumps.
The @patternfly/patternfly -> @rh-felt/styles alias keeps its registry
pin because styles is not a workspace in this repo; a stale pin there
only lags the published CSS package and cannot break installs.
Verified: yarn install --immutable passes; a simulated version bump
to an unpublished 0.0.1-prerelease.5 keeps every alias linked to its
workspace with no manifest changes; yarn build and yarn build:docs
pass.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Follow-up to #12705 — makes the docs
@patternfly/*aliases immune to release version bumps, so the YN0028 CI breakage can't recur.Additional issues: Follow-up to #12699 / #12705 (PF-4694)
Background
#12705 fixed the failing Release workflow by bumping three stale alias pins, but the root cause remains: the aliases pin exact versions, which must match the workspace versions for yarn to link them to the local packages. Every release of an aliased package re-creates the drift — and release commits are
[ci skip], so the breakage is invisible until the next CI run fails withYN0028.The fix
Replace the exact pins with workspace ranges:
The
npm:<name>@workspace:^form binds each alias to the local workspace regardless of its current version, so releases no longer require lockstep pin bumps. (Correction to a note in #12705: yarn 4 does support aliasing to workspaces —npm:<name>@workspace:<range>is the working syntax; theworkspace:<name>form tried there is the one yarn rejects.)The
@patternfly/patternfly→@rh-felt/stylesalias keeps its registry pin because@rh-felt/stylesis not a workspace in this repo; a stale pin there only lags the published CSS package and cannot break--immutableinstalls.The aliases themselves remain temporary scaffolding until the Felt-compatible documentation framework lands (PF-4694 follow-up) — this just makes them maintenance-free in the meantime.
Verification
yarn install --immutablepasses (the invocation CI uses)packages/*; lockfile descriptors merge the alias and workspace entries0.0.1-prerelease.5— the aliases stayed linked to the workspace, resolved the new version with zero manifest edits, and--immutablestill passed (the exact scenario that broke felt-v1 on Oct 30)yarn buildandyarn build:docspass