[2.7.9]#4
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependencies and includes bug fixes for version 2.7.9. The main changes involve:
- Dependency updates including @types/chrome, vitest, @iconify/json, mermaid, minimatch, and AWS SDK packages
- Bug fixes for the Comet Isolated Zoom plugin and Better Language Model Selector
- Refactoring of the post-update announcer and release notes system
- UI/UX improvements for the thread TOC panel
- Optimization of query client persistence logic
Reviewed Changes
Copilot reviewed 137 out of 139 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml, pnpm-lock.yaml | Updates @types/chrome from 0.1.24 to 0.1.27 and vitest from 4.0.3 to 4.0.4 |
| perplexity/extension/src/services/infra/query-client/utils.ts | Adds query state validation and infinite query pagination optimization |
| perplexity/extension/src/plugins/comet-isolated-zoom/* | Fixes zoom gesture handling and adds manual zoom control |
| perplexity/extension/src/plugins/thread-toc/* | Refactors TOC panel positioning logic and component structure |
| perplexity/extension/src/plugins/ui-groups/routes/Home/* | Redesigns post-update release notes system |
| perplexity/extension/src/components/ExtensionUpdateInfoDialogWrapper.tsx | Improves extension update dialog UI |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const url = useSpaRouter((store) => store.url); | ||
|
|
||
| const calculatePosition = useCallback(() => { | ||
| void (isSidebarPinned && windowSize != null && url != null); |
There was a problem hiding this comment.
This line uses a void statement to reference variables for dependency tracking in useCallback, but doesn't actually use them in the calculation logic. This is a code smell that suggests the dependency array might be incorrect. Consider removing unused dependencies from the useCallback if they don't affect the calculation, or actually use them if they should.
| const threadWrapperOffset = $firstChild.offset(); | ||
| if (!threadWrapperOffset) return null; | ||
| if (!threadWrapperOffset) { | ||
| console.log("threadWrapperOffset is null"); |
There was a problem hiding this comment.
Debug console.log statement should be removed from production code or replaced with a proper logging mechanism.
| }} | ||
| > | ||
| <CommandItemTitle className="x:line-clamp-3 x:break-words x:whitespace-pre-wrap"> | ||
| <CommandItemTitle className="x:line-clamp-3 x:wrap-break-word x:whitespace-pre-wrap"> |
There was a problem hiding this comment.
The CSS class 'x:wrap-break-word' appears to be a typo. The correct Tailwind utility class should be 'x:break-words'. The current class may not apply any styling.
| @@ -177,7 +177,7 @@ export class PplxApiService { | |||
| ascending, | |||
| thread_type_filter: threadTypeFilter, | |||
| query_source_filter: querySourceFilter, | |||
| with_temporary_threads: withTemporaryThreads, | |||
| with_temporary_threads: withTemporaryThreads ? undefined : false, | |||
There was a problem hiding this comment.
The ternary expression 'withTemporaryThreads ? undefined : false' is unclear. If withTemporaryThreads is true, the parameter is set to undefined (which omits it), otherwise it's explicitly set to false. Consider adding a comment explaining why undefined is used instead of true, or refactor for clarity.
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
…for message blocks
This pull request introduces several improvements and updates across the extension's issue templates, documentation, localization, dependencies, and changelogs. The main focus is on refining user-facing templates for bug reports and feature requests, updating translations for clarity, upgrading dependencies for stability, and providing detailed changelog information for the latest release.
Issue Template & Documentation Improvements
.github/ISSUE_TEMPLATE/bug_report.yml) was restructured for clarity: the browser/version input is now required, the reproduction steps and expected behavior sections were reorganized, and debug log instructions were added. Markdown greetings and screenshot fields were removed for conciseness. [1] [2]Localization Updates
Dependency Upgrades
vitest,@iconify/json,mermaid, andminimatchinpackage.jsonfiles. [1] [2] [3] [4] [5] [6]Changelog & Release Updates
package.json.Documentation & Task Command Refinements