Generate a random SRT socket ID for each connection - #2206
Open
michelsbautzen wants to merge 1 commit into
Open
michelsbautzen wants to merge 1 commit into
michelsbautzen wants to merge 1 commit into
Conversation
Owner
|
Hello, This error should be already fixed in the version 2.8.1. Can you confirm that it is fixed using 2.8.1? |
Author
|
Yes, I can confirm that the issue is fixed in version 2.8.1. I was able to receive both SRT streams from the phones successfully. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The SRT handshake currently uses a fixed socket ID (
762640158/0x2D74F71E).This can cause problems when multiple Android devices using RootEncoder connect simultaneously to the same SRT server.
I encountered this issue using two Android devices with Opticast and MediaMTX. Both devices could connect individually, but the second connection failed while the first one was active.
A Wireshark capture showed that both devices were using the same SRT socket ID:
0x2D74F71EThis change generates a random socket ID instead of using the fixed value.
Testing
Tested with:
Before the change, only one device could connect at a time.
After the change, both devices can stream simultaneously through the same MediaMTX SRT listener.