Skip to content

SEP-1869: Add recurring Trivy scan gate to CI for the SEP container image - #1386

Draft
yyyyyyyan with Copilot wants to merge 2 commits into
mainfrom
copilot/sep-1869-add-recurring-trivy-scan
Draft

SEP-1869: Add recurring Trivy scan gate to CI for the SEP container image#1386
yyyyyyyan with Copilot wants to merge 2 commits into
mainfrom
copilot/sep-1869-add-recurring-trivy-scan

Conversation

Copilot AI commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

.trivyignore.yaml (added by SEP-1864) is inert — no CI step invokes Trivy, so dependency bumps can silently reintroduce HIGH/CRITICAL CVEs with nothing to catch it.

Changes

  • Path filter (changes job): added .trivyignore.yaml and .github/workflows/ci.yml to the sidecar filter so edits to either file trigger the build job — including this PR itself.
  • Trivy scan step (build job): after the existing smoke tests, installs Trivy v0.69.3 (matching the version .trivyignore.yaml entries were validated against) and scans sep:HEAD:
- name: Trivy image scan
  run: >-
    trivy image
    --ignorefile .trivyignore.yaml
    --severity HIGH,CRITICAL
    --exit-code 1
    "sep:HEAD"

--ignorefile is required because Trivy's default ignore file is .trivyignore (no .yaml extension) — without it the YAML-format exception list is silently ignored and all twelve accepted findings re-fail.

Heads-up

The current .trivyignore.yaml entries carry expired_at: 2027-02-19. After that date the gate will start failing on its own until the entries are revisited.

Co-authored-by: yyyyyyyan <24644216+yyyyyyyan@users.noreply.github.com>
Copilot AI changed the title [WIP] SEP-1869: Add recurring Trivy scan gate to CI for the SEP container image SEP-1869: Add recurring Trivy scan gate to CI for the SEP container image Aug 20, 2026
Copilot AI requested a review from yyyyyyyan August 20, 2026 22:36
@yyyyyyyan
yyyyyyyan requested a balanced review from Copilot August 21, 2026 15:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Trivy vulnerability scanning for the SEP container image, including relevant CI path triggers.

Changes:

  • Triggers container builds for Trivy configuration and CI changes.
  • Installs Trivy v0.69.3 and scans for HIGH/CRITICAL vulnerabilities.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/ci.yml
Comment on lines +340 to +343
- name: Install Trivy
run: |
curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh \
| sh -s -- -b /usr/local/bin v0.69.3
Comment thread .github/workflows/ci.yml
Comment on lines +342 to +343
curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh \
| sh -s -- -b /usr/local/bin v0.69.3
Comment thread .github/workflows/ci.yml
Comment on lines +345 to +351
- name: Trivy image scan
run: >-
trivy image
--ignorefile .trivyignore.yaml
--severity HIGH,CRITICAL
--exit-code 1
"sep:HEAD"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants