SEP-1868: Report success when alerts push recreates a missing PMM rule

[olucasandrade]

Summary

• When POST /api/apps/alerts/push finds a template already registered in PMM, it no longer always reports skipped / Already present in PMM.
• If create_rule succeeds (the rule was missing, including after an out-of-band delete), the item is success / Pushed successfully.
• A genuine rule-name collision ("conflicts with existing" in the error detail) still reports skipped. Any other create_rule failure is error with the real detail, not swallowed.
• Relates to SEP-1868. Out of scope: GET /api/apps/alerts/ in_pmm still means template presence only.

Tested

• Log in at http://localhost:5174 (backend is SEP-1868 on :8000; Casdoor :9999; PMM :8443).
• Open Alerts → Alert Templates (/alerts/templates/). Confirm PMM is connected (no "PMM not connected" warning).
• Check a template that is not already in PMM, click Push Selected, confirm Push to PMM. Expect a green check and Pushed successfully.
• In PMM/Grafana, delete only the alert rule for that template (leave the template registered).
• Back in SEP, the list still shows In PMM (template presence — unchanged). Select the same template and push again. Expect a green check and Pushed successfully, not a warning Already present in PMM.
• Push the same template a third time without deleting the rule. Expect a warning icon and Already present in PMM.
• Regression: a template that was never pushed still creates both template and rule and reports Pushed successfully.

Checklist

• New/modified functions have type hints and rST docstrings
• New tests added for new features or bug fixes
• Covering tests pass locally (pytest tests/app/sep/apps/alerts/ — 189 passed). Full make test not re-run; no OpenAPI/schema change so make regen-specs was not run
• Pre-commit hooks pass (ran on both commits)
• Database migrations generated if models changed (make makemigrations) (N/A)
• User-facing changes documented (README, inline help, UI text) (N/A — changelog fragment covers the push-result copy)
• Configuration changes documented with examples (N/A)
• Changelog fragment added under changelog.d/ if the change is user-facing (make changelog-add), or confirmed N/A (internal-only change, or a same-release-cycle fix for an unreleased sibling ticket)

[Copilot]

Pull request overview

Updates alert push results to distinguish recreated rules, existing-rule conflicts, and genuine failures.

Changes:

• Reports successful missing-rule recreation.
• Preserves skipped status for collisions and surfaces other errors.
• Adds regression tests and a changelog fragment.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
app/sep/apps/alerts/api_routes.py	Refines push-result handling.
tests/app/sep/apps/alerts/test_api_routes.py	Tests revised result states.
changelog.d/SEP-1868.fixed.md	Documents the fix.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
app/sep
inventory.py
app/sep/apps/alerts
api_routes.py
Project Total

This report was generated by python-coverage-comment-action