Skip to content

SEP-1788: Validate detail_view paths against the serialized row - #1394

Draft
olucasandrade wants to merge 1 commit into
mainfrom
SEP-1788
Draft

SEP-1788: Validate detail_view paths against the serialized row#1394
olucasandrade wants to merge 1 commit into
mainfrom
SEP-1788

Conversation

@olucasandrade

@olucasandrade olucasandrade commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Align the detail-view conformance check with the list-view column gate: compare each detail_view path root against serialized_field_names(detail_model) instead of model_fields.

  • An excluded root (Field(exclude=True)) is now reported; a @computed_field root is accepted; an aliased field is accepted only under its wire name.
  • Path grammar is unchanged (data.* exemption, root-segment-only resolution, _detail_response_model fallback). No live app views or response models needed a patch.

SEP-1788

Tested

  • Open PostgreSQL Backups (/backups/postgresql), open an existing task detail, confirm hostname / host / port / backup_type / created_at / updated_at still render (not em-dashes)
  • Open MySQL Backups → Restore, open an existing restore detail, confirm hostname / destination host / destination port still render
  • Confirm /admin/apps still loads and no app is newly blocked by the conformance suite (CI test_registry_migrated_app_structural_checks)

Checklist

  • New/modified functions have type hints and rST docstrings
  • New tests added for new features or bug fixes
  • All tests pass locally (make test) (covering framework suite 249 passed / 11 skipped; full suite 10060 passed; 82 pre-existing sidecar declare -A failures on macOS bash and 1 pre-existing AES256 restore round-trip — neither touched by this change)
  • Pre-commit hooks pass (make run-pre-commit) (commit hooks + make lint exit 0)
  • Database migrations generated if models changed (make makemigrations) (N/A)
  • User-facing changes documented (README, inline help, UI text) (N/A)
  • Configuration changes documented with examples (N/A)
  • Changelog fragment added under changelog.d/ (N/A — internal conformance detector; no live UI change)

The list_view column gate already uses serialized_field_names; the
detail-view conformance check still used model_fields, so excluded
roots were silent and computed/aliased roots were false positives.
@olucasandrade olucasandrade self-assigned this Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant