SEP-1788: Validate detail_view paths against the serialized row - #1394
Draft
olucasandrade wants to merge 1 commit into
Draft
SEP-1788: Validate detail_view paths against the serialized row#1394olucasandrade wants to merge 1 commit into
olucasandrade wants to merge 1 commit into
Conversation
The list_view column gate already uses serialized_field_names; the detail-view conformance check still used model_fields, so excluded roots were silent and computed/aliased roots were false positives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the detail-view conformance check with the list-view column gate: compare each
detail_viewpath root againstserialized_field_names(detail_model)instead ofmodel_fields.Field(exclude=True)) is now reported; a@computed_fieldroot is accepted; an aliased field is accepted only under its wire name.data.*exemption, root-segment-only resolution,_detail_response_modelfallback). No live app views or response models needed a patch.SEP-1788
Tested
/backups/postgresql), open an existing task detail, confirmhostname/host/port/backup_type/created_at/updated_atstill render (not em-dashes)hostname/ destination host / destination port still render/admin/appsstill loads and no app is newly blocked by the conformance suite (CItest_registry_migrated_app_structural_checks)Checklist
make test) (covering framework suite 249 passed / 11 skipped; full suite 10060 passed; 82 pre-existing sidecardeclare -Afailures on macOS bash and 1 pre-existing AES256 restore round-trip — neither touched by this change)make run-pre-commit) (commit hooks +make lintexit 0)Database migrations generated if models changed ((N/A)make makemigrations)User-facing changes documented (README, inline help, UI text)(N/A)Configuration changes documented with examples(N/A)Changelog fragment added under(N/A — internal conformance detector; no live UI change)changelog.d/