K8SPG-1051 add upgrade image for pg19 - #1389
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a PostgreSQL 19 (beta) upgrade image to support pg_upgrade from PostgreSQL 18 → 19, while also pinning the PG19 build to a specific beta and aligning pgBackRest to a version compatible with that beta’s WAL format.
Changes:
- Introduces a new
upgrade19container image that contains both PostgreSQL 18 and 19 binaries (plus required preloadable extensions like pgAudit). - Pins PostgreSQL 19 packages to
beta3via build args to avoid silent beta drift. - Updates pgBackRest builds for PG19 to
2.59.1to support the beta3 WAL format.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| postgresql-containers/community/Makefile | Adds upgrade19 target and includes it in the PG19 build/list-image groups. |
| postgresql-containers/community/build/upgrade19/Dockerfile | New upgrade image with PG18 + PG19 binaries and pgAudit built for PG19 beta. |
| postgresql-containers/community/build/postgres19/Dockerfile | Pins PG19 beta package selection and bumps pgBackRest build to 2.59.1. |
| postgresql-containers/community/build/pgbackrest19/Dockerfile | Bumps pgBackRest build to 2.59.1 for PG19 beta compatibility. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
58
to
60
| # The PGDG pgbackrest rpm does not support PostgreSQL 19 yet — build | ||
| # pgBackRest 2.59.0 (first release with PG 19 support) from the official dist | ||
| # tarball and overlay the binary. Drop this stage once the PGDG rpm catches up. |
hors
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the high volume of requests, we're unable to provide free service for this account. To continue using the service, please upgarde to a paid plan.
Problem:
There is no image to run pg_upgrade for 18 -> 19. The existing upgrade image only has PostgreSQL up to 18, and pg_upgrade needs both old and new binaries in one container. Also our pg19 builds were not pinned to a beta, so a rebuild silently jumped from beta2 to beta3. beta3 changed the WAL format, pgBackRest 2.59.0 stopped accepting WAL — no archiving, no backups.
Solution:
New upgrade19 image with 18 and 19 binaries. Pin the build to beta3 with a build arg, so switching to the next beta is an explicit change. Update pgBackRest to 2.59.1, which supports beta3 WAL.