PT-1923: Replace offensive terminology (master/slave → primary/replica) in pt-pg-summary - #1161
Open
guriandoro wants to merge 1 commit into
Open
PT-1923: Replace offensive terminology (master/slave → primary/replica) in pt-pg-summary#1161guriandoro wants to merge 1 commit into
guriandoro wants to merge 1 commit into
Conversation
Rename master/slave to primary/replica across the pt-pg-summary tool: report output labels, the pginfo collector fields, the xo-generated models (and models/gen.sh so a future regeneration stays consistent), main.go, and the tool docs. No behavior change: the underlying pg_is_in_recovery() and pg_stat_replication queries are untouched; only identifiers, labels, and comments change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PT-1923: Offensive terminology elimination (Group 3, PostgreSQL)
Replaces
master/slavewithprimary/replicaacrosspt-pg-summary,the only PostgreSQL-specific tool in the toolkit. All occurrences were the
tool's own naming — PostgreSQL itself never uses these terms; the SQL simply
aliased
pg_is_in_recovery()asIs_Slaveand read frompg_stat_replication.Changes
Replicas and the lag with Primary,There are no replica hosts,Is Replicalib/pginfo:ReplicaHosts96/10fields, log/error stringsmodels/:IsReplica, SQL aliasIs_Replica,slavehosts{10,96}.xo.go→replicahosts{10,96}.xo.gomodels/gen.shupdated soxoregeneration reproduces the new namesREADME.rst, symlinked asdocs/pt-pg-summary.rst)No functional change. Verified:
gofmtclean,go build,go vetpass.