Skip to content

Pplt 6073 : Make regression tolerance higher - #2431

Merged
RaghavsBrowserStack merged 1 commit into
release-1.32.10from
PPLT-6073_forwardcleanup
Sep 16, 2026
Merged

Pplt 6073 : Make regression tolerance higher#2431
RaghavsBrowserStack merged 1 commit into
release-1.32.10from
PPLT-6073_forwardcleanup

Conversation

@RaghavsBrowserStack

@RaghavsBrowserStack RaghavsBrowserStack commented Sep 16, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Release

    • Promoted the Percy 1.32.10 packages from beta to the stable release channel.
    • Updated package publishing and internal version alignment to 1.32.10.

  • Bug Fixes

    • Improved validation coverage for oversized PDF uploads and undersized rasterized pages.
    • Updated PDF rendering regression tolerances to account for known nondeterministic differences while continuing to detect significant changes.

@RaghavsBrowserStack
RaghavsBrowserStack requested a review from a team as a code owner September 16, 2026 13:13
@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Workspace UI

Review profile: CHILL

Plan: Advanced

Run ID: 4ac0377c-1de8-4890-8ab5-06bdd3cbc041

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Workspace UI

Review profile: CHILL

Plan: Advanced

Run ID: 6ac8f5b6-8083-479d-b8f0-d265a0b30c79

📥 Commits

Reviewing files that changed from the base of the PR and between b90cd9f and d1339ef.

📒 Files selected for processing (22)
  • lerna.json
  • packages/cli-app/package.json
  • packages/cli-build/package.json
  • packages/cli-command/package.json
  • packages/cli-config/package.json
  • packages/cli-doctor/package.json
  • packages/cli-exec/package.json
  • packages/cli-pdf/package.json
  • packages/cli-snapshot/package.json
  • packages/cli-upload/package.json
  • packages/cli/package.json
  • packages/client/package.json
  • packages/config/package.json
  • packages/core/package.json
  • packages/core/test/pdf-snapshot.test.js
  • packages/dom/package.json
  • packages/env/package.json
  • packages/logger/package.json
  • packages/monitoring/package.json
  • packages/sdk-utils/package.json
  • packages/webdriver-utils/package.json
  • test/regression/pdf-render.test.js

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The PR promotes the repository packages from beta 1.32.10-beta.1 to stable 1.32.10, changes publish tags to latest, aligns internal dependencies, and adds PDF boundary tests and regression tolerance updates.

Changes

Stable release promotion

Layer / File(s) Summary
Package versions, publish tags, and dependencies
lerna.json, packages/*/package.json		 Package versions change to 1.32.10. Publish tags change from beta to latest. Internal @percy/* dependencies change to matching stable versions.

PDF validation updates

Layer / File(s) Summary
PDF boundary and size tests
packages/core/test/pdf-snapshot.test.js		 Tests cover an 8x8px rasterized page error and rejection of decoded PDF content above 50MB.
PDF regression tolerance
test/regression/pdf-render.test.js		 Regression documentation includes thin-rule anti-aliasing. The jack-sparrow-resume differing-pixel limit increases from 600 to 2,000; the channel-delta and size checks remain unchanged.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Other

Suggested reviewers: rishigupta1599

Merge Risk: ⚪ Minimal · up to d1339

The release promotion and PDF validation updates do not show a concrete current-head risk requiring changes before merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the increase to the PDF regression tolerance, which is a real change. However, the main change is the promotion of packages from beta to the stable 1.32.10 release.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch PPLT-6073_forwardcleanup

Comment @coderabbitai help to get the list of available commands.

@RaghavsBrowserStack @claude
PPLT-6073: close the PDF coverage gaps and widen the resume tolerance
96d0cc6 
Two CI failures on the 1.32.10 release PR, neither a product bug.

Regression (Track P): `jack sparrow resume.pdf` diffed by 648 pixels against
a 600 budget, in box [369, 1447, 692, 1448] at a channel delta of 4. That box
is not the circular photo clip the 600 was measured against — it is the
hairline rule under the LANGUAGES heading, whose two pixel rows are the only
non-white rows across those 324 columns. A second, previously unmeasured
source of run-to-run jitter on a fixed Chromium build (the manifest browser
and the run browser matched, so the goldens are not stale). Budget raised to
2000, ~2x the 918-pixel worst case of both sources landing at once and still
0.1% of the page, with the second source documented.

@percy/core: all 1322 specs passed; the job failed nyc's 100% threshold on
two uncovered spots.

  - pdf-rasterize.js:128, the asInputError rethrow when a rendered page comes
    back under Percy's 10px floor. fitScale only clamps the upper bound, so a
    4x4pt MediaBox rasterizes to 8x8 at scale 2 and trips it. The new test
    also pins that this surfaces as a 400, not a 500.
  - pdf-snapshot.js:67-68, the decoded-size check. The existing oversize test
    trips the encoded cap first, leaving the decoded one unreachable. The cap
    rounds up to a whole base64 quantum, so 52428801 bytes encodes to exactly
    MAX_PDF_BASE64_CHARS and clears it — the two-byte window the second check
    exists to close.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@RaghavsBrowserStack
RaghavsBrowserStack changed the base branch from master to release-1.32.10 September 16, 2026 13:23
@RaghavsBrowserStack
RaghavsBrowserStack merged commit 1b144bb into release-1.32.10 Sep 16, 2026
50 of 51 checks passed
@RaghavsBrowserStack
RaghavsBrowserStack deleted the PPLT-6073_forwardcleanup branch September 16, 2026 13:23
@RaghavsBrowserStack
RaghavsBrowserStack restored the PPLT-6073_forwardcleanup branch September 16, 2026 13:29
@rishigupta1599
rishigupta1599 deleted the PPLT-6073_forwardcleanup branch September 16, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RaghavsBrowserStack