Skip to content

fix: keep rejected plan resolves transactional - #684

Open
ApexWorm wants to merge 1 commit into
peteromallet:mainfrom
ApexWorm:fix/plan-resolve-transaction
Open

fix: keep rejected plan resolves transactional#684
ApexWorm wants to merge 1 commit into
peteromallet:mainfrom
ApexWorm:fix/plan-resolve-transaction

Conversation

@ApexWorm

Copy link
Copy Markdown

Problem

desloppify plan resolve wrote a done execution-log entry before the generic resolver enforced queue order. An out-of-order request could therefore leave the plan claiming completion while the issue remained open in state.

Fix

Remove the premature wrapper write so the generic resolver is the first persistence path after all resolve guards pass. Add a regression using real state and plan files to prove a rejected out-of-order resolution leaves both unchanged.

Verification

  • python3 -m pytest -q desloppify/tests/commands/plan desloppify/tests/commands/test_queue_order_guard.py
  • python3 -m ruff check desloppify/app/commands/plan/override/resolve_cmd.py desloppify/tests/commands/plan/test_plan_override_transactions.py desloppify/tests/commands/plan/test_plan_overrides_direct.py desloppify/tests/commands/plan/test_workflow_gates.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant