fix: keep rejected plan resolves transactional - #684
Open
ApexWorm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
desloppify plan resolvewrote adoneexecution-log entry before the generic resolver enforced queue order. An out-of-order request could therefore leave the plan claiming completion while the issue remained open in state.Fix
Remove the premature wrapper write so the generic resolver is the first persistence path after all resolve guards pass. Add a regression using real state and plan files to prove a rejected out-of-order resolution leaves both unchanged.
Verification
python3 -m pytest -q desloppify/tests/commands/plan desloppify/tests/commands/test_queue_order_guard.pypython3 -m ruff check desloppify/app/commands/plan/override/resolve_cmd.py desloppify/tests/commands/plan/test_plan_override_transactions.py desloppify/tests/commands/plan/test_plan_overrides_direct.py desloppify/tests/commands/plan/test_workflow_gates.py