Skip to content

feat: implement issue #414 — Compliance: non-stub-feature-ideation.yml #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
don-petry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: implement issue #414 — Compliance: non-stub-feature-ideation.yml #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 56 additions & 14 deletions .github/workflows/feature-ideation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,19 @@ on:
required: false
default: false
type: boolean
enhance_backlog:
description: "Backlog enhancement sweep: enhance this repo's open, human-authored, not-yet-enhanced Ideas (one comment each, idempotent). Combine with dry_run=true to preview."

@don-petry don-petry Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in .github/workflows/feature-ideation.yml line 68: changed the enhance_backlog input description from double-quoted to single-quoted style, with the apostrophe in repo's escaped as repo''s per YAML single-quote escaping rules. This matches the canonical org template verbatim to avoid textual-diff compliance flags.

@don-petry don-petry Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction to my prior reply: the single-quote form with '' escaping was applied, but the mandatory npx prettier --write . pass (required by AGENTS.md) immediately normalized it back to double quotes. Prettier chooses double quotes for YAML strings that contain an apostrophe even when singleQuote: true is set in .prettierrc, because the '' escape sequence is valid YAML but less readable. The semantic content is identical either way. If the compliance check compares files textually against the org template, the fix would need to land in Prettier's YAML formatter or the org template should be canonicalized through this repo's Prettier config first — both would converge to the same double-quote form. The file is currently in the Prettier-canonical form that passes npm run check.

required: false
default: false
type: boolean
target_discussion:
description: 'Internal — set by `redispatch` when bridging a `discussion:created` event to workflow_dispatch (claude-code-action does not support discussion contexts). Not for manual use.'
required: false
default: ''
type: string
# Auto-enhance a freshly-created idea: when a new Discussion is opened in the
# Ideas category, the analyst researches and refines it in single-idea mode.
# Ideas category, the `redispatch` job bridges it to workflow_dispatch (see below)
# so the analyst refines it in single-idea mode under a supported event.
discussion:
types: [created]

Expand All @@ -76,15 +87,44 @@ concurrency:
cancel-in-progress: false

jobs:
ideate:
# On the `discussion` trigger, only run for new ideas in the Ideas category
# and skip the bot's own creations (avoids re-enhancing scheduled output;
# enhancement posts a comment, which does not re-fire `discussion: created`).
# Schedule/dispatch runs are unaffected by this guard.
# ── #963 discussion→dispatch redispatch bridge ───────────────────────────────
# claude-code-action aborts on `discussion` event contexts ("Unsupported event
# type: discussion"). So on `discussion: created` we do NOT call the reusable
# inline; the `redispatch` job re-invokes this workflow via workflow_dispatch
# (under which the action runs cleanly), passing the number as target_discussion.
# Mirrors initiative-planner.yml's redispatch (#618). The `ideate` reusable call
# then runs only on workflow_dispatch/schedule.
redispatch:
if: >-
github.event_name != 'discussion' ||
(github.event.discussion.category.slug == 'ideas' &&
github.event.discussion.user.type != 'Bot')
github.event_name == 'discussion' &&
github.event.discussion.category.slug == 'ideas' &&
github.event.discussion.user.type != 'Bot'
runs-on: ubuntu-latest
timeout-minutes: 5
permissions: {}
steps:
- name: Guard — PAT present
# A workflow_dispatch fired with GITHUB_TOKEN is accepted but never starts
# a run (loop prevention), so a PAT is required (same as initiative-planner).
env:
GH_TOKEN: ${{ secrets.GH_PAT_WORKFLOWS }}
run: |
if [ -z "${GH_TOKEN}" ]; then
echo "::error::GH_PAT_WORKFLOWS is required — a workflow_dispatch fired with GITHUB_TOKEN will not start a run."
exit 1
fi
- name: Re-dispatch under workflow_dispatch
env:
GH_TOKEN: ${{ secrets.GH_PAT_WORKFLOWS }}
REPO: ${{ github.repository }}
DISCUSSION_NUMBER: ${{ github.event.discussion.number }}
run: |
gh workflow run feature-ideation.yml --repo "${REPO}" \
-f target_discussion="${DISCUSSION_NUMBER}"

ideate:
# Runs on workflow_dispatch (including the redispatch bridge above) and schedule.
if: github.event_name != 'discussion'
# Permissions cascade from the calling job to the reusable workflow.
# The reusable workflow's two jobs (gather-signals + analyze) need:
# - contents: read (checkout, file reads)
Expand All @@ -100,12 +140,12 @@ jobs:
discussions: write
id-token: write
actions: read
uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@c2beceb1c3ffcaf7981db22d168de669c9fdf816 # v1
uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@e20a8fac1b6a10bd6ad0999258e88a423f890ba6 # v1
with:
# On the `discussion: created` trigger this carries the new Discussion's
# number → the reusable runs single-idea enhancement mode. Empty on
# schedule/dispatch → normal scan. Do not edit this line.
target_discussion: ${{ github.event.discussion.number }}
# Populated by the `redispatch` bridge above (which forwards the new
# Discussion number on `discussion: created`); empty on schedule/dispatch →
# normal scan. Do not edit this line.
target_discussion: ${{ inputs.target_discussion || '' }}
# === CUSTOMISE THIS PER REPO — the only required edit ===
# Replace this paragraph with a 3-5 sentence description of your project,
# its target users, and the competitive landscape. The more specific you
Expand All @@ -123,5 +163,7 @@ jobs:
focus_area: ${{ inputs.focus_area || '' }}
research_depth: ${{ inputs.research_depth || 'standard' }}
dry_run: ${{ inputs.dry_run || false }}
# Backlog enhancement sweep of existing un-enhanced Ideas (workflow_dispatch).
enhance_backlog: ${{ inputs.enhance_backlog == true }}
secrets:
CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
Loading