fix: correct loadEnv.php path in scraper jobs upload endpoint - #1117
Merged
Conversation
Path from v1/scraper/jobs/upload/ needs 4 levels up (../../../../) not 3 (../../../) to reach root util/loadEnv.php. Same pattern as v1/firme/company/add/.
- Fix TestValidation: case-sensitive string comparison ('at least one' -> 'At least one')
- Fix v1/random/index.php: use PROD_SERVER instead of SOLR_SERVER to match test env
- Uncomment v1/cleanjobs/index.php endpoint (entire code was commented out)
- Create v1/empty/index.php endpoint (was missing entirely)
- Change REPORT_FILE from tests/report/index.html to tests/report.html - Remove old tests/report/ directory from git - Add tests/results.json and cleanjobs.log to .gitignore
- Replace PROD_SERVER with SOLR_SERVER in all 12 endpoints - Add PROTOCOL env var for URL construction (replace hardcoded http://) - Update test env and docs to match - Remove v1/empty endpoint and its tests (reduce risk of mass data deletion)
…b-endpoints Missed 23 nested files under v1/firme/ and v1/scraper/jobs/ in the previous commit. All endpoints now consistently use SOLR_SERVER + PROTOCOL.
AndreiBarari
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/v1/scraper/jobs/upload/returns a PHP fatal error:The file
v1/scraper/jobs/upload/index.phpis 4 directories deep from root but only goes up 3 levels (../../../), resolving tov1/util/loadEnv.phpinstead ofutil/loadEnv.php.Fix
Change
../../../to../../../../— same pattern used byv1/firme/company/add/index.phpwhich is at the same depth.