fix: escape spaces in company name search query for Solr - #1130
Merged
Conversation
Use SOLR_SERVER/PROTOCOL env vars and escape spaces with backslash instead of rawurlencode, which double-encoded the query via http_build_query and caused company name searches with spaces to return nothing. Fixes #1126.
ale23yfm
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1126
Problem
GET /v1/company/?name=EVOLUTION%20PROreturned nothing, even thoughEVOLUTION PRODUCTS RO S.R.L.exists in the company core.The old code built the query with
rawurlencode($name), turning the space into%20, whichhttp_build_querythen encoded again (%2520). Solr received a literal%20and matched no documents.Fix
\\) for Solr syntax instead ofrawurlencode, so spaces in company names are searched correctly.SOLR_SERVERandPROTOCOLenv vars instead of hardcodedhttp://+PROD_SERVER.Verified locally
?name=EVOLUTION%20PRO-> returnsEVOLUTION PRODUCTS RO S.R.L.?name=EVOLUTION-> 18 companies?cif=36034853-> correct company; unknown CIF -> 404