Repository navigation
complete the relationship as you type - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing a relationship and pressing Enter did nothing. The token field adds what you typed, so "fr" came in as "fr", and
sanitizeXfn()drops everything that is not in the XFN vocabulary, so it vanished without a word. You had to press the arrow keys or click a suggestion to get anywhere.Two props on the token field fix it: the first match is preselected, so "fr" becomes
friendand "co-w" becomesco-worker, and a word that is no relationship stays in the field instead of being swallowed.Checked in the editor: "fr" + Enter gives friend, "co-w" + Enter gives co-worker, "nonsense" + Enter adds nothing and stays in the field.