Skip to content

Rebase our react-data-grid fork onto current upstream #10611

Open

Description

@dpage

pgAdmin installs react-data-grid from our fork, pgadmin-org/react-data-grid, pinned by commit in web/package.json. The fork is upstream 7.0.0-beta.58 plus one commit of our own (8ddaa7be, cell range selection), and is now about 255 commits behind adazzle/react-data-grid, which is at 7.0.0-beta.60. We should rebase the fork onto current upstream and update pgAdmin to match.

This isn't a fast-forward, as upstream has made breaking changes that affect both the fork commit and pgAdmin:

  • onSelectedCellChange (used in pgAdmin) is now onActivePositionChange, part of a selectedPosition to activePosition rename; selectCell, which the range selection code relies on, has changed too.
  • The rdg-cell-copied class, which pgAdmin styles, has been removed.
  • textEditor has been renamed to renderTextEditor.
  • Rows are now focusable and the focus sink element has been removed, which changes the keyboard and focus handling the range selection code is built on.
  • The build moved from rolldown to tsdown, and biome and the old ESLint setup were replaced.

So the work is: rebase the range selection commit (and the shift + click change from pgadmin-org/react-data-grid#9, if merged by then) onto upstream, rebuild lib/, bump the pin in pgAdmin, and update the Query Tool, View/Edit Data and schema dialog grids for the API changes. The Selenium feature tests need to pass as well as Jest, as grid problems in dialogs don't show up in the unit tests. In return we get upstream's fixes since beta.58 and React 19.3 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions