Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
murex971
marked this pull request as ready for review
September 14, 2026 20:01
Collaborator
|
👀 |
levkk
reviewed
Sep 15, 2026
| describe.anonymize(); | ||
| } | ||
| if let Some(describe) = describe { | ||
| return Ok(HandleResult::PrependProtocolMessageRewrite { |
Collaborator
There was a problem hiding this comment.
Q: why do we need this? I'm not too familiar with this piece of code, would be good to have a small example explaining.
levkk
reviewed
Sep 15, 2026
levkk
reviewed
Sep 15, 2026
| })) | ||
| } | ||
|
|
||
| fn internal_describe(&mut self, name: &str) -> Option<ProtocolMessage> { |
Collaborator
There was a problem hiding this comment.
Oh I see. The cross-shard Describe has different columns that direct-to-shard, so we need to rewrite it. I'm remembering now.
levkk
reviewed
Sep 15, 2026
|
|
||
| impl GlobalCache { | ||
| pub(crate) fn cross_shard_variant_name(&self, name: &str) -> Option<String> { | ||
| let variant_name = format!("{name}_cross_shard"); |
Collaborator
There was a problem hiding this comment.
This should be a helper. I saw it copy/pasted somewhere else.
levkk
reviewed
Sep 15, 2026
| if let Some(variant_name) = self.cross_shard_variant_name(name) { | ||
| return Some(variant_name); | ||
| } | ||
| let variant_name = format!("{name}_cross_shard"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aggregate helpers, ORDER BY helpers, and LIMIT/OFFSET pushdown now run only after the route is known, so direct shard execution keeps original SQL and does not leak helper columns.
closes #1425 #1135