docs: 2026-07-02 deep review + ISSUES triage (I143–I160) - #90
Merged
Conversation
…ES.md Adds the fresh-eyes review report (docs/reviews/review-20260702-001902.md) and triages its verified findings as I143–I160 under a new "Deep review 2026-07-02" section in ISSUES.md. - 18 findings confirmed by adversarial verification (0 refuted): 4 BUG, 13 DESIGN, 1 SMELL. Prior-review delta: 0 regressions, 71 resolved. - I143–I146 (the BUGs) are marked FIXED (PR #89). - I147–I160 (DESIGN/SMELL) recorded OPEN for triage — corrupt-page hardening asymmetry, KDF-param DoS, per-page replay, the encrypted-minor write-gate off-by-series, Python finished-transaction aliasing, and the encrypted on-disk-spillway test gap are the notable ones. Docs only; no code change.
🚦 Bench results: PR vs main
Per-scenario detail (4 metrics × cells)document-store
mutation-log
ycsb-a
ycsb-b
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records the fresh-eyes Rust deep review run at
581be36and triages its findings into ISSUES.md.docs/reviews/review-20260702-001902.md(full, canonical).What the review found
Method: 8 category reviewers over the full engine + Python binding + bench harness; every BUG/DESIGN finding put through an independent adversarial verifier before inclusion.
--tests, wheel-gate release-only, etc.) were not re-filed.Disposition
(2,1)file, Python finished-transaction aliasing, and the missing encrypted × on-disk-spillway integration test.Docs only; no code change.