Skip to content

feat(client): expose pinned debug click mode control#5152

Merged
matthewevans merged 1 commit into
mainfrom
ship/expose-pinned-debug-click-mode-control
Jul 5, 2026
Merged

feat(client): expose pinned debug click mode control#5152
matthewevans merged 1 commit into
mainfrom
ship/expose-pinned-debug-click-mode-control

Conversation

@matthewevans

Copy link
Copy Markdown
Member

No description provided.

@matthewevans matthewevans enabled auto-merge July 5, 2026 17:16

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a dedicated sandbox dropdown menu within the game menu, allowing users to open sandbox tools and toggle the visibility of a quick floating click-mode button. It also adds corresponding state management in useUiStore, localization keys across multiple languages, and unit tests. The feedback suggests a UX improvement to keep the sandbox dropdown menu open when toggling the click-mode button visibility, rather than closing it immediately.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +233 to +236
onClick={() => {
onToggleDebugClickModeButtonVisible();
setSandboxOpen(false);
}}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Closing the dropdown menu immediately when toggling a setting (like the click mode button visibility) can be jarring for users who might want to perform multiple actions or verify the toggle state. Consider keeping the menu open by omitting setSandboxOpen(false) here.

Suggested change
onClick={() => {
onToggleDebugClickModeButtonVisible();
setSandboxOpen(false);
}}
onClick={() => {
onToggleDebugClickModeButtonVisible();
}}

@matthewevans matthewevans added this pull request to the merge queue Jul 5, 2026
Merged via the queue into main with commit 97e4daf Jul 5, 2026
11 checks passed
@matthewevans matthewevans deleted the ship/expose-pinned-debug-click-mode-control branch July 5, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant