Repository navigation
fix(headers): preserve PHP 8.3 compatibility without mbstring - #14
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 9
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Changelog✅ Contribution check passed. Head: Base: Contribution: 1 new valid fragment(s). Policy: ordinary.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Fixes #9.
HTTP OWS is defined by RFC 9110 §5.6.3; strtolower is locale-independent ASCII-only since PHP 8.2. This intentionally stops treating NBSP/other Unicode whitespace as HTTP OWS. It is not a generic Unicode mb_trim replacement.
Validation
Limits / remaining validation
composer install --no-devphp tests/fixtures/header-runtime.php ./vendor/autoload.php