mcrypt: fix MCRYPT_ENIGMA to the real MCRYPT_ENIGNA and add MCRYPT_BLOWFISH_COMPAT#5667
Closed
lacatoire wants to merge 1 commit into
Closed
mcrypt: fix MCRYPT_ENIGMA to the real MCRYPT_ENIGNA and add MCRYPT_BLOWFISH_COMPAT#5667lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
ciphers.xml listed MCRYPT_ENIGMA, but the extension registers the constant as MCRYPT_ENIGNA (a long-standing misspelling in mcrypt.c: MCRYPT_ENTRY2_2_4(ENIGNA, "crypt")), so MCRYPT_ENIGMA does not exist. Also add the registered but undocumented MCRYPT_BLOWFISH_COMPAT constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cipher list documented
MCRYPT_ENIGMA, but the constant registered by ext/mcrypt is spelledMCRYPT_ENIGNA(see ext/mcrypt/mcrypt.c:MCRYPT_ENTRY2_2_4(ENIGNA, "crypt")), so the documented name never existed.Also adds
MCRYPT_BLOWFISH_COMPAT, which is registered (MCRYPT_ENTRY2_2_4(BLOWFISH_COMPAT, "blowfish-compat")) but was missing from the list.