Repository navigation
sem_get(): warn that auto_release also applies when the semaphore is freed - #5963
Merged
Merged
Conversation
lacatoire
reviewed
Oct 19, 2026
lacatoire
requested changes
Oct 19, 2026
lacatoire
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a warning to the Notes: with auto_release enabled, the semaphore is released as soon as the SysvSemaphore object is freed (unset, overwritten or out of scope), not only at request shutdown.
I didn't add it to the 8.0.0 changelog entry as suggested in the issue, because it doesn't look like it changed with the resource to object conversion. In 7.4 the release happened in the resource destructor, which also ran as soon as the resource was freed. Checked the snippet from the issue on PHP 8.4.
Fixes #3612