Repository navigation
gmp_random_seed(): update example for PHP 8 - #5965
Merged
lacatoire merged 1 commit intoOct 19, 2026
Merged
Conversation
The example called gmp_random(), which was removed in PHP 8.0.0, and showed the warning and false return that gmp_random_seed() no longer produces. Use gmp_random_bits()/gmp_random_range() and catch the ValueError instead, and drop gmp_random() from the related functions. Fixes php#1387
lacatoire
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example still called
gmp_random(), which was removed in PHP 8.0.0, and showed the warning andfalsereturn thatgmp_random_seed()no longer produces (it throws aValueErroras of PHP 8.0.0, as the changelog already says).The example now uses
gmp_random_bits()andgmp_random_range()and catches theValueError. The output was checked with PHP 8.4.gmp_random()is also dropped from the parameter description and the See also list.Fixes #1387