[Sync-En] snmp: factor out the SNMPv3 security parameter descriptions - #1176
Open
lacatoire wants to merge 1 commit into
Open
[Sync-En] snmp: factor out the SNMPv3 security parameter descriptions#1176lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
Mirrors php/doc-en#5228 (commit 1ab1069) for reference/snmp. The SNMPv3 security parameter descriptions were duplicated by hand across six pages and had drifted apart. They are now defined once in language-snippets.ent as snmp.parameter.* entities, translated into Spanish, and the pages reference them. This fixes several errors the Spanish pages carried: - snmp3_get(), snmp3_getnext(), snmp3_real_walk() and snmp3_walk() described privacy_protocol with the authentication protocols ("MD5", "SHA", "SHA256", "SHA512"), which it does not accept - snmp3_set() documented timeout in milliseconds instead of microseconds - SNMP::setSecurity() had no changelog section at all - SNMP::__construct() described the community parameter in terms of the security level, and hostname as suffixed after a comma rather than a colon - the examples used the SNMP_VERSION_* constants instead of SNMP::VERSION_* The privacy protocol list is completed the same way as EN ("AES128" as an alias of "AES", plus "AES192", "AES192C", "AES256" and "AES256C"). language-snippets.ent also gains mbstring.errors.encoding-invalid and mbstring.changelog.encoding-invalid, added upstream by an intermediate commit: without them the file would claim to mirror 1ab1069 while missing part of it. Fixes: php#1164
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors php/doc-en#5228 (commit 1ab1069) for
reference/snmp. The SNMPv3 security parameter descriptions were duplicated by hand across six pages and had drifted apart; they are now defined once inlanguage-snippets.entassnmp.parameter.*entities, translated into Spanish, and referenced by the pages.This fixes real errors the Spanish pages carried, notably
privacy_protocoldescribed with the authentication protocols on four pages, andsnmp3_set()documentingtimeoutin milliseconds instead of microseconds.language-snippets.entalso gains the twombstring.*.encoding-invalidentities added upstream by an intermediate commit, without which its EN-Revision would be inaccurate.Fixes: #1164